Update to Go 1.25 #1577
Merged
Update to Go 1.25 #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to use Go 1.25, upgrading from Go 1.24. The change aims to improve compilation performance based on the PR description "Goodbye, slow compile times."
- Updates Go version specification in module files from 1.24 to 1.25
- Updates gofumpt language version flag from go1.24 to go1.25 across all generation scripts
- Updates GitHub Actions workflows and documentation to reflect the new Go version requirement
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates main module Go version from 1.24.2 to 1.25 |
| _tools/go.mod | Updates tools module Go version from 1.24.0 to 1.25 |
| _tools/customlint/testdata/go.mod | Updates testdata module Go version from 1.24.0 to 1.25 |
| README.md | Updates documentation to specify Go 1.25 or higher requirement |
| .github/workflows/create-cache.yml | Simplifies Go version matrix to use 1.25.0 instead of 1.24.0 with special cases |
| .github/workflows/copilot-setup-steps.yml | Removes explicit Go version override, now using default |
| .github/actions/setup-go/action.yml | Updates default Go version from 1.24.0 to 1.25.0 |
| .dprint.jsonc | Updates gofumpt language flag from go1.24 to go1.25 |
| Multiple internal files | Updates gofumpt language flag in go:generate directives from go1.24 to go1.25 |
iisaduan
approved these changes
Aug 13, 2025
sheetalkamat
approved these changes
Aug 13, 2025
weswigham
approved these changes
Aug 13, 2025
Does go 1.25 improve compile times? I didn't see anything mentioned |
|
It's sort of niche to us, but yes, see golang/go#72815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goodbye, slow compile times
There is no need to update the release pipelines (not in this repo), since I configured them to extract the Go version from
go.mod. Phew.golangci-linttechnically does not support this yet (golangci/golangci-lint#5873), but since we custom build the binaries, it works fine.